PDA

View Full Version : New skin available for download



sub
2004-04-08, 11:42 PM
I've just upload gplasky's new skin for GB-PVR. You can download it form the skins page http://www.gbpvr.com/skins.htm



http://www.gbpvr.com/images/preview-mcelike.jpg


Thanks Gerry!

CodeMonkey
2004-04-09, 03:00 AM
Looks good. *But no 'Weather' button shows up. *There is no weather subdirectory for mce_like. *I copied the weather subdir from the blue skin into mce_like and the button does show up (with a different look of course) but gb-pvr crashes when I select that weather button.

Also, the instructions on the skins download page says to extract to the gbpvr subdir, when actually you have to extract to the gbpvr/skin directory.

Keep up the good work. *The more skins the better http://gbpvr.com/iB_html/non-cgi/emoticons/smile.gif

gplasky
2004-04-09, 12:07 PM
Looks like some of the stuff for weather is hard coded in the plugin. Because I can't assign a graphic to show up when you go to the weather button I keep getting an exception. The weather module doesn't use an xml file to define any screen elements. I'll have to get some help fom sub on this.

Gerry

TypQxQ
2004-04-09, 01:10 PM
The problem is in getTaskImage().
There are two getSkinSubdirectory() so the path becomes:
.\skin\MCE like\weatherweather\task.png

/Andrei

TypQxQ
2004-04-09, 01:25 PM
I would recomend a public shared function like this:

private static string skinRoot = PluginHelperFactory.getPluginHelper().GetSkinRootD irectory();
private static string skinDefaultRoot = PluginHelperFactory.getPluginHelper().GetDefaultSk inRootDirectory();
public Image getSkinedImage(string imageName, string skinSubDirectory)
{
if (System.IO.File.Exists(skinRoot + skinSubDirectory + "\\" + imageName))
return Image.FromFile(skinRoot + skinSubDirectory + "\\" + imageName);
else if (System.IO.File.Exists(skinDefaultRoot + skinSubDirectory + "\\" + imageName))
return Image.FromFile(skinDefaultRoot + skinSubDirectory + "\\" + imageName);
else
return new Bitmap(1,1);
}

sub
2004-04-09, 06:58 PM
Yes, I was thinking of exactly that. If you can think of any other useful plugin functions just let me know.

CodeMonkey
2004-04-09, 07:43 PM
Quote[/b] (TypQxQ @ April 09 2004,07:25)]I would recomend a public shared function like this:

private static string skinRoot = PluginHelperFactory.getPluginHelper().GetSkinRootD irectory();
private static string skinDefaultRoot = PluginHelperFactory.getPluginHelper().GetDefaultSk inRootDirectory();
public Image getSkinedImage(string imageName, string skinSubDirectory)
{
if (System.IO.File.Exists(skinRoot + skinSubDirectory + "\\" + imageName))
return Image.FromFile(skinRoot + skinSubDirectory + "\\" + imageName);
else if (System.IO.File.Exists(skinDefaultRoot + skinSubDirectory + "\\" + imageName))
return Image.FromFile(skinDefaultRoot + skinSubDirectory + "\\" + imageName);
else
return new Bitmap(1,1);
}
Yeah, that way it will go grab the default if the selected skin doesn't have a directory for a plugin.

gplasky
2004-04-09, 08:39 PM
So if this change is made this will work with a icon called task.png in the skins\weather directory?

Gerry

mamema
2004-04-09, 08:48 PM
@gplasky

have you used a special tool to create the buttons or did you made it manually?

sub
2004-04-09, 09:17 PM
Gerry, there was a bug with the weather plugin that was looking for the task image in "skin\MCE Like\WeatherWeather". I've corrected this for the next release.

I've also started making some changes to make the skinning more flexible. If anyone has suggestions, now is a good time to let me know http://gbpvr.com/iB_html/non-cgi/emoticons/biggrin.gif

gplasky
2004-04-09, 09:32 PM
Quote[/b] (mamema @ April 09 2004,19:48)]@gplasky

have you used a special tool to create the buttons or did you made it manually?
I did everything in Photoshop. Background, buttons, icons. Also used Axialis IconWorkshop to work with the icons.

Gerry